Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to VS 2017 #776

Merged
merged 5 commits into from
Jan 19, 2019

Conversation

martingbrown
Copy link
Contributor

I've created a new pull request for this as #700 doesn't seem to be getting anywhere.

I have:

  • updated all the projects in all the solutions to Visual Studio 2017.
  • updated the projects in the BlogRunner.sln to point to the correct location for their dependencies and made it prefer 32 bit[1].
  • written a build.ps1 file for the build as the old build.cmd was having trouble finding MSBuild where VS 2017 installs it. The way MS recommend to find it is with a powershell module.
  • changed the old build.cmd to simply call the new build.ps1 script.
  • updated the appveyor config to use the Visual Studio 2017 image.
  • updated the version number by one minor point. This stops Squirrel from erroring during the build.
  • re-targeted the Ribbon project.
  • changed some of the projects that were compiling against .Net Framework 2 to compile against .Net Framework 4.6.1

Some things I haven't done:

Both these issues are already in the master branch and felt like they were outside the scope of this change.

[1] The projects in the BlogRunner.sln appear to be duplicated in both $/Utilities/BlogRunner/ and $/src/Managed/ I only modified the one in the utilities directory as the other seemed to be set up ok. I made it prefer 32 bit as the output of the write.sln projects are mostly x86 even though the build is set for Any CPU.

Martin Brown added 5 commits November 4, 2018 19:44
Re-writes build script in powershell using MS Recommended techinque for finding ms-build
Changes version number by one
Also fixed invalid dll references and processor architecture
Upgraded the projects to use .Net Framework 4.6.1
@dariuszparys
Copy link

@jongalloway PR works on my machine

@jongalloway jongalloway merged commit 4fd4215 into OpenLiveWriter:master Jan 19, 2019
@jongalloway
Copy link
Contributor

Works for me. Thanks so much for a great pull request and thorough description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants