Allow certificates for SSL to be accepted. #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottIsAFool
changed the title
aviade
suggested changes
Jul 25, 2017
| @@ -268,6 +268,7 @@ public static HttpWebRequest CreateHttpWebRequest(string requestUri, bool allowA | |||
| request.UserAgent = ApplicationEnvironment.UserAgent; | |||
|
|
|||
| ApplyProxyOverride(request); | |||
| ServicePointManager.ServerCertificateValidationCallback = AcceptAllCerts; | |||
There was a problem hiding this comment.
Why override the static ServerCertificateValidationCallback every time that we create request? If ignoring invalid/unsafe certs is by design why not do it in the static constructor?
Also - this will override the cert validation callback that we do it the static constructor
if (ApplicationDiagnostics.AllowUnsafeCertificates)
{
ServicePointManager.ServerCertificateValidationCallback = new RemoteCertificateValidationCallback(CheckValidationResult);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully addressing #580