Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File changed #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

File changed #22

wants to merge 3 commits into from

Conversation

harshkraj
Copy link

No description provided.

@thunderboltsid
Copy link
Member

thunderboltsid commented Oct 31, 2016 •
edited

@harshkraj Please refer to the blog post on how to write a git commit message. Also, the PR is insufficient to warrant a merge.

@thunderboltsid
Copy link
Member

thunderboltsid commented Oct 31, 2016 •
edited

@harshkraj Thanks for the changes. Please remove the first commit. The second and third seem good. Please squash them into one commit and adhere to the proper commit message guidelines outlined by the blogpost above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harshkraj @thunderboltsid