Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - Update GrowattSPF.cpp #331

Closed

Conversation

TheHexaMaster
Copy link

@TheHexaMaster TheHexaMaster commented Apr 4, 2024

Battery Power used wrong size. Correct is sigend 32BIT (SIZE_32BIT_S). Updated modbus second fragment size (from 3 to 4 pos).

Description

Please include a summary of the change and which issue is fixed.

How Has This Been Tested?

  • Not applicable

Inverter type

SPF 6000 ES

Stick type

Lolin32

Battery Power used wrong size. Correct is sigend 32BIT (SIZE_32BIT_S). Updated modbus second fragment size (from 3 to 4 pos).
Copy link
Author

@TheHexaMaster TheHexaMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget to secondary thing - sGrowattReadFragment_t{77, 80}; is wrong, right one shall be sGrowattReadFragment_t{77, 4};

@crasu
Copy link
Collaborator

crasu commented Apr 6, 2024

Thank you for contribution.

Could you please fix the dco check by running:

git commit —amend —no-edit ---signoff

See:
https://www.secondstate.io/articles/dco/#:~:text=If%20you%20encounter%20a%20failing,the%20DCO%20check%20will%20pass.

Could you fix the format check by running:

docker build -t clang-format-lint github.com/DoozyX/clang-format-lint-action
docker run -it --rm --workdir /src -v $(pwd):/src clang-format-lint --clang-format-executable /clang-format/clang-format15 -r -i true SRC

@crasu
Copy link
Collaborator

crasu commented May 27, 2024

Closing due to no response from OP.

@crasu crasu closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants