Gnome mousetweaks4 #16255
Open
Gnome mousetweaks4 #16255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You accidentally deleted files in |
TWE: Fixup commit
Toasterson
force-pushed
the
gnome-mousetweaks4
branch
from
eba54c7
to
e73ff78
Compare
|
@isoriano1968 asked me via chat if I can cleanup the commit I think I finally found out how :) |
mtelka
reviewed
Feb 24, 2024
| # This file sets up the standard, default options and base requirements for | ||
| # GNOME userland components. | ||
| # | ||
| COMPONENT_PROJECT_URL ?= https://www.gnome.org/ |
There was a problem hiding this comment.
We already have gnome.mk. No need to introduce something similar.
mtelka
reviewed
Feb 24, 2024
| REQUIRED_PACKAGES += x11/library/libxfixes | ||
| REQUIRED_PACKAGES += x11/library/libxtst | ||
| # Auto-generated dependencies | ||
| REQUIRED_PACKAGES += library/desktop/cairo |
There was a problem hiding this comment.
I do not think it is good idea to bring this from solaris-userland. We already diverged too much and many things makes no sense here when copied verbatim or are even counterproductive.
This is fairly simple component so package it from scratch should be straightforward. And you would also get much smaller Makefile. For example here are duplicate dependencies. Above is COMPONENT_BAID, etc.
mtelka
reviewed
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
mousetweaks is one of the many packages to bring GNOME 3 to OI.
Cheers
Iggi