Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Docker container #527

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

maol-corteva
Copy link

This pull request adds a Dockerfile and instructions to build the container. It builds the image by pulling a pre-compiled binary version from the distribution (not compilation required)

#############

# FROM scratch
FROM ubuntu:20.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about alpine which is more smaller

# Update the repository sources list
RUN apt-get update && apt-get install -y \
wget \
nano \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nowhere to use nano?

# fastp v0.23.4
WORKDIR /app
RUN wget http://opengene.org/fastp/fastp.${FP_VERSION} \
&& mv fastp.${FP_VERSION} fastp \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to use ln -s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants