Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] lower limit to openff version? #837

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mikemhenry
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.13%. Comparing base (3b76941) to head (6779e09).

❗ Current head 6779e09 differs from pull request most recent head be403e4. Consider uploading reports for the commit be403e4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   94.13%   92.13%   -2.01%     
==========================================
  Files         134      134              
  Lines        9786     9786              
==========================================
- Hits         9212     9016     -196     
- Misses        574      770     +196     
Flag Coverage Δ
fast-tests 92.13% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Contributor Author

ERROR openfe/tests/protocols/test_openmm_equil_rfe_protocols.py::test_tip4p_check_vsite_parameters - ValueError: No registered small molecule template generators could load force field 'openff-2.1.1'

we can't use openff-toolkit =0.13.x

@mikemhenry mikemhenry changed the title [DNM] see if we can use 0.16 [DNM] lower limit to openff version? Apr 19, 2024
@mikemhenry
Copy link
Contributor Author

Well at least not with openff-2.1.1 ff, so since that is the only error, it might work with an older ff version

@IAlibay
Copy link
Contributor

IAlibay commented Apr 21, 2024

I'm really not sure how 0.13 handles things like NAGL - it might be best not to go below 0.14 if we can avoid it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants