Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect if API breaks on PR #727

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Feb 16, 2024

Developers certificate of origin

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.32%. Comparing base (378147c) to head (9620de2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   94.13%   92.32%   -1.81%     
==========================================
  Files         134      134              
  Lines        9786     9786              
==========================================
- Hits         9212     9035     -177     
- Misses        574      751     +177     
Flag Coverage Δ
fast-tests 92.32% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Contributor Author

mikemhenry commented Feb 16, 2024

See https://mkdocstrings.github.io/griffe/checking/#detected-breakages

We get errors, but that is because we are breaking things, after the 1.0 tag, we can use this check to make sure we update the change log with breakage.

For example:
https://github.com/OpenFreeEnergy/openfe/actions/runs/7925490023/job/21638754579?pr=727#step:4:65

@mikemhenry mikemhenry marked this pull request as ready for review February 16, 2024 06:39
Copy link
Contributor

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool @mikemhenry - I personally like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants