Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting #723

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Add linting #723

wants to merge 9 commits into from

Conversation

mikemhenry
Copy link
Contributor

@mikemhenry mikemhenry commented Feb 13, 2024

Developers certificate of origin

@mikemhenry
Copy link
Contributor Author

black 120 chars

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 205 lines in your changes are missing coverage. Please review.

Comparison is base (60a5eca) 93.73% compared to head (804a657) 91.89%.

Files Patch % Lines
openfe/utils/handle_trajectories.py 0.00% 36 Missing ⚠️
...tests/protocols/test_openmm_equil_rfe_protocols.py 86.34% 31 Missing ⚠️
...enfe/protocols/openmm_rfe/_rfe_utils/multistate.py 51.11% 22 Missing ⚠️
openfe/analysis/plotting.py 50.00% 16 Missing ⚠️
openfecli/commands/gather.py 65.11% 15 Missing ⚠️
openfe/tests/protocols/test_openmm_afe_slow.py 26.31% 14 Missing ⚠️
.../protocols/openmm_rfe/_rfe_utils/lambdaprotocol.py 64.86% 13 Missing ⚠️
openfe/protocols/openmm_rfe/equil_rfe_methods.py 88.09% 10 Missing ⚠️
openfe/protocols/openmm_utils/omm_settings.py 82.75% 10 Missing ⚠️
openfe/tests/protocols/conftest.py 79.48% 8 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   93.73%   91.89%   -1.84%     
==========================================
  Files         133      133              
  Lines        9650     9645       -5     
==========================================
- Hits         9045     8863     -182     
- Misses        605      782     +177     
Flag Coverage Δ
fast-tests 91.89% <89.79%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry mikemhenry force-pushed the feat/add_linting branch 2 times, most recently from d3e06e5 to 19b0c2f Compare February 16, 2024 06:53
@mikemhenry
Copy link
Contributor Author

using isort on openfe/setup/__init__.py gives me errors like

E   ImportError: cannot import name 'LomapAtomMapper' from partially initialized module 'openfe.setup' (most likely due to a circular import) (/home/mmh/Projects/openfe/openfe/setup/__init__.py)

@IAlibay
Copy link
Contributor

IAlibay commented Apr 25, 2024

From today's call: to be discussed in an upcoming power hour.

@mikemhenry
Copy link
Contributor Author

I have the same PR on GUFE, so we can talk about linting-org wide on a power hour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants