Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP: don't review] New storage in network planner CLI #470

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dwhswenson
Copy link
Member

This will add a flag to use our new storage to output an alchemical network in the CLI network planners. For now, this option is hidden (doesn't show in --help), so we have full freedom to change the UX later. That way we can dogfood new storage with actual release code.

As of pushing the PR, nothing is actually hooked into storage. Just giving a heads-up that I'll be working on it.

@dwhswenson dwhswenson changed the title Start new storage in network planner CLI [WIP: don't review] New storage in network planner CLI Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 72.18% and project coverage change: -0.39 ⚠️

Comparison is base (9e6766e) 91.99% compared to head (abed241) 91.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
- Coverage   91.99%   91.61%   -0.39%     
==========================================
  Files         106      110       +4     
  Lines        6324     6557     +233     
==========================================
+ Hits         5818     6007     +189     
- Misses        506      550      +44     
Impacted Files Coverage Δ
openfe/setup/atom_mapping/ligandatommapper.py 91.66% <ø> (-0.65%) ⬇️
openfe/tests/conftest.py 100.00% <ø> (ø)
openfe/utils/handle_trajectories.py 0.00% <0.00%> (ø)
openfecli/tests/commands/test_gather.py 100.00% <ø> (ø)
openfecli/commands/plan_rbfe_network.py 93.44% <66.66%> (-4.71%) ⬇️
openfe/tests/protocols/test_openmmutils.py 96.72% <78.57%> (-3.28%) ⬇️
openfecli/commands/gather.py 92.04% <88.46%> (+6.12%) ⬆️
openfe/protocols/openmm_rfe/_rfe_utils/relative.py 83.06% <95.00%> (+1.00%) ⬆️
openfe/protocols/openmm_rfe/equil_rfe_methods.py 93.87% <100.00%> (+4.34%) ⬆️
openfe/protocols/openmm_rfe/equil_rfe_settings.py 86.82% <100.00%> (+5.54%) ⬆️
... and 10 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant