Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal documentation lacks dependency management policy #4614

Merged
merged 1 commit into from
May 8, 2024

Conversation

jrw972
Copy link
Contributor

@jrw972 jrw972 commented May 1, 2024

Problem

The internal (developer) documentation lacks the policy used for managing the dependencies of OpenDDS.

Solution

Add it.

@jrw972
Copy link
Contributor Author

jrw972 commented May 1, 2024

What about vcpkg?

@iguessthislldo
Copy link
Member

This makes it sound like we're not using any branch of ACE/TAO in PR CI at all. With that, I'm concerned about having newly merged features in ACE/TAO and able to test that those are working correctly with an OpenDDS PR CI that's trying to use them.

@jrw972
Copy link
Contributor Author

jrw972 commented May 3, 2024

This makes it sound like we're not using any branch of ACE/TAO in PR CI at all. With that, I'm concerned about having newly merged features in ACE/TAO and able to test that those are working correctly with an OpenDDS PR CI that's trying to use them.

If a PR requires an unreleased feature of ACE/TAO, then the PR author is free to change the ACE/TAO versions from release to the branches for the purpose of CI. However, I would push back against merging such a PR until the feature makes it into a released version of ACE/TAO at which point the ACE/TAO versions could be updated to a release version.

@iguessthislldo
Copy link
Member

I would suggest something like an environment variable in the workflows to make it easier to switch the PRs to use git branches and maybe a lint check to make sure we don't accidentally merge that.

Problem
-------

The internal (developer) documentation lacks the policy used for
managing the dependencies of OpenDDS.

Solution
--------

Add it.
@jrw972 jrw972 force-pushed the dependency-management-policy branch from 9d8a633 to 37ff5a8 Compare May 7, 2024 17:39
@iguessthislldo iguessthislldo merged commit 81660e1 into OpenDDS:master May 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants