Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added another FACE example with two topics #4607
base: master
Are you sure you want to change the base?
Added another FACE example with two topics #4607
Changes from all commits
1c7c3f5
08ebcc0
b31ea3e
d69f789
4c3f0cd
32598d7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testing is missing for both CMake and MPC. The Simple example isn't doing this though, so I guess it'd be hard to come up with that from scratch. https://github.com/OpenDDS/OpenDDS/blob/master/tests/FACE/Messenger/run_test.pl should do without the callback and subdirectory stuff. You'd also need to add the test to https://github.com/OpenDDS/OpenDDS/blob/master/tests/dcps_tests.lst. Again FACE messenger should do, but without the callback lines probably:
OpenDDS/tests/dcps_tests.lst
Lines 457 to 460 in 3afd105
Let me know if you need further guidance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't know where to start