Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make seconds of Time_t 64bit #4425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jwillemsen
Copy link
Member

Fixed #4365

    * dds/DCPS/Time_Helper.inl:
    * dds/DdsDcpsCore.idl:
    * dds/DdsDcpsInfoUtils.idl:
@jrw972
Copy link
Contributor

jrw972 commented Jan 15, 2024

This will break the interoperability of applications that use DDS::Time_t. We will definitely make this change for OpenDDS 4. Can you wait for OpenDDS 4?

@jwillemsen
Copy link
Member Author

This could break portability, interoperability is handled by RTPS and there is another different definition on time. The risk is very small, all Time_t is created by the OpenDDS core and passed to user code where they can use it. At the moment they use Time_t as type nothing will happen, the only risk is when they use another 32bit type to store it, at that moment they would get a warning, easily fixed by changing to 64bit also or add a cast. This is a break in portability we should do asap to my idea, not wait because we maybe cause a warning somewhere for just a few users.

@jrw972
Copy link
Contributor

jrw972 commented Jan 17, 2024

The risk is for applications that use DDS::Time_t like tools/ dds/rtpsrelay/Relay.idl.

@iguessthislldo
Copy link
Member

We have added this to the roadmap under OpenDDS 4.0.

@jrw972 jrw972 added this to the 4.0 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DDS::Time_t for 64bit
3 participants