Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement @optional annotation #4364

Open
wants to merge 157 commits into
base: master
Choose a base branch
from
Open

Implement @optional annotation #4364

wants to merge 157 commits into from
+660 −442

Commits on Nov 22, 2023

  1. updated test

    @tmayoff
    tmayoff committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2460409 View commit details
    Browse the repository at this point in the history

  2. start on rough implementation

    @tmayoff
    tmayoff committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c5a6265 View commit details
    Browse the repository at this point in the history

  3. todo

    @tmayoff
    tmayoff committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2067e9d View commit details
    Browse the repository at this point in the history

  4. ValueReade/Writer generation

    @tmayoff
    tmayoff committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    17ddd27 View commit details
    Browse the repository at this point in the history

  5. fixed build errors

    @tmayoff
    tmayoff committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    ba1428b View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. add gtest to optional test

    @tmayoff
    tmayoff committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    ccf9455 View commit details
    Browse the repository at this point in the history

  2. Added support for serialization functions

    @tmayoff
    tmayoff committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    6be278f View commit details
    Browse the repository at this point in the history

  3. extended tests

    @tmayoff
    tmayoff committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    1794a2d View commit details
    Browse the repository at this point in the history

  4. fixed lint

    @tmayoff
    tmayoff committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    6f44dc7 View commit details
    Browse the repository at this point in the history

  5. Added another optional test

    @tmayoff
    tmayoff committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    00f998b View commit details
    Browse the repository at this point in the history

  6. ^

    @tmayoff
    tmayoff committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    801a714 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    734cc57 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. add googletest to mpc

    @tmayoff
    tmayoff committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    5595efc View commit details
    Browse the repository at this point in the history

  2. mpc options

    @tmayoff
    tmayoff committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    4762462 View commit details
    Browse the repository at this point in the history

  3. Fixed test, and final code gen

    @tmayoff
    tmayoff committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    c86171c View commit details
    Browse the repository at this point in the history

  4. use 0 not nullptr

    @tmayoff
    tmayoff committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    bfed4f5 View commit details
    Browse the repository at this point in the history

  5. Serialize the has_value of optional

    @tmayoff
    tmayoff committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    d549aec View commit details
    Browse the repository at this point in the history

  6. proper defaulting of optional

    @tmayoff
    tmayoff committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    b9e5f0e View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. updates to tests

    @tmayoff
    tmayoff committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    2fd23ed View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    ecb8241 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Some fixes to CMake setup

    @tmayoff
    tmayoff committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ba74b43 View commit details
    Browse the repository at this point in the history

  2. Fixed some more copy/paste bugs in cmake build 

    Tests now failing with static libs
    @tmayoff
    tmayoff committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    8a9968f View commit details
    Browse the repository at this point in the history

  3. Fixed tests to work with static libs

    @tmayoff
    tmayoff committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    8844ae6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7bbe231 View commit details
    Browse the repository at this point in the history

  5. Cleaned up some code, set cmake C++ version

    @tmayoff
    tmayoff committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    14e7cea View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Added a cxx_17 config for MPC

    @tmayoff
    tmayoff committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    e7745f4 View commit details
    Browse the repository at this point in the history

  2. Add no_cxx17 to configure script

    @tmayoff
    tmayoff committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9092820 View commit details
    Browse the repository at this point in the history

  3. Add opendds_cxx17 to MPC compiler test for optional

    @tmayoff
    tmayoff committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    724b1e8 View commit details
    Browse the repository at this point in the history

  4. Fixed missing comma

    @tmayoff
    tmayoff committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3e02ca9 View commit details
    Browse the repository at this point in the history

  5. Updated cmake tests to compile IDLs with C++17

    @tmayoff
    tmayoff committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    edd1a07 View commit details
    Browse the repository at this point in the history

  6. Added to compiler tests 

    fixed an issue with multiple optional values in a struct
    @tmayoff
    tmayoff committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    9b65b9f View commit details
    Browse the repository at this point in the history

  7. Merge branch 'optional' of github.com:tmayoff/OpenDDS into optional

    @tmayoff
    tmayoff committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    601396d View commit details
    Browse the repository at this point in the history

  8. Use typedef in test

    @tmayoff
    tmayoff committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    eccc5bd View commit details
    Browse the repository at this point in the history

  9. Fix for generating std::nullopt when it shouldn't 

    type_to_default, in more places we generate with is_optional than we do
is_union, so I placed is_optional first in the function definition this
broke it in a single place. Will need to decide which is easier to get,
the is_optional from the generateCaseBody or the is_union from the other
places we call type_to_default.
    @tmayoff
    tmayoff committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3717a57 View commit details
    Browse the repository at this point in the history

  10. Switched to order of the arguments

    @tmayoff
    tmayoff committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    20c4b01 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Fixing tests

    @tmayoff
    tmayoff committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    e21cd7e View commit details
    Browse the repository at this point in the history

  2. Fixed crash with serialization functions

    @tmayoff
    tmayoff committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    78756cf View commit details
    Browse the repository at this point in the history

  3. Fixed deserialization for real this time, tests passing locally

    @tmayoff
    tmayoff committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    a64a5c0 View commit details
    Browse the repository at this point in the history

  4. Fixed warning

    @tmayoff
    tmayoff committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    833361c View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Updated mpc files

    @tmayoff
    tmayoff committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    fb94d5e View commit details
    Browse the repository at this point in the history

  2. Add optional to tests

    @tmayoff
    tmayoff committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    e26eac2 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Add extra () to some code gen

    @tmayoff
    tmayoff committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    fb3987a View commit details
    Browse the repository at this point in the history

  2. Revert "Add extra () to some code gen" 

    This reverts commit fb3987a.
    @tmayoff
    tmayoff committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    9019966 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    872999a View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Formatting + consolidated configure script ifs

    @tmayoff
    tmayoff committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b80dbc5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'optional' of github.com:tmayoff/OpenDDS into optional

    @tmayoff
    tmayoff committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a04b2a1 View commit details
    Browse the repository at this point in the history

  3. Fixed copy-paste bug

    @tmayoff
    tmayoff committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    732ce89 View commit details
    Browse the repository at this point in the history

  4. Removed no_cxx17=0 from MSVC and remove opendds_cxx11 from tests

    @tmayoff
    tmayoff committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    88691ef View commit details
    Browse the repository at this point in the history

  5. Fixed optional test configuration

    @tmayoff
    tmayoff committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ee61ec0 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'optional' of github.com:tmayoff/OpenDDS into optional

    @tmayoff
    tmayoff committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    e12ec8f View commit details
    Browse the repository at this point in the history

  7. Update tests/dcps_tests.lst 

    Co-authored-by: Adam Mitz <mitza@objectcomputing.com>
    @tmayoff @mitza-oci
    tmayoff and mitza-oci committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    4bc51d3 View commit details
    Browse the repository at this point in the history

  8. Bump cache prefix

    @tmayoff
    tmayoff committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    0b69bde View commit details
    Browse the repository at this point in the history

  9. Merge branch 'optional' of github.com:tmayoff/OpenDDS into optional

    @tmayoff
    tmayoff committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d36569a View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Added XCDR2 test, 

    serialized_size isn't quite right
    @tmayoff
    tmayoff committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    e1b7c25 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Serialization test with comparing bytes 

    Currently struggling with getting the actual bytes layout correct
    @tmayoff
    tmayoff committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ee8ce39 View commit details
    Browse the repository at this point in the history

  2. Remove some codegen in favour of Serializer funcs 

    I may need to readd some codegen for certain code paths, but this felt
seemed like a better solution
    @tmayoff
    tmayoff committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a411e5d View commit details
    Browse the repository at this point in the history

  3. Added guards to the Serializer functions, 

    added more fields to the tests
    @tmayoff
    tmayoff committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    cf6f834 View commit details
    Browse the repository at this point in the history

  4. Moved function into #if

    @tmayoff
    tmayoff committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a8c8305 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Reverted to codegen stuff 

    I saved the experiment in a branch but fails on every older compiler,
and I can't debug it at the moment. Need to readd deserialization

This now passes the tests comparing bytes.
    @tmayoff
    tmayoff committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    a0c5bb2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    ba323f2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    0ea901c View commit details
    Browse the repository at this point in the history

  4. Removed templated >>

    @tmayoff
    tmayoff committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    8e87e91 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Update configure 

    Co-authored-by: Fred Hornsey <fred@hornsey.us>
    @tmayoff @iguessthislldo
    tmayoff and iguessthislldo committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    9911509 View commit details
    Browse the repository at this point in the history

  2. Update dds/idl/langmap_generator.cpp 

    Co-authored-by: Fred Hornsey <fred@hornsey.us>
    @tmayoff @iguessthislldo
    tmayoff and iguessthislldo committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    418e109 View commit details
    Browse the repository at this point in the history

  3. Discard changes to dds/DCPS/Serializer.h

    @tmayoff
    tmayoff committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    30c7197 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Merge remote-tracking branch 'origin/main' into optional

    @tmayoff
    tmayoff committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    7d9da5c View commit details
    Browse the repository at this point in the history

  2. Little bit of cleanup 

    still not sure how to debug the segfault in CI builds
    @tmayoff
    tmayoff committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    227f1a5 View commit details
    Browse the repository at this point in the history

  3. Added an extra nullcheck

    @tmayoff
    tmayoff committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    2fb4e94 View commit details
    Browse the repository at this point in the history

  4. Fixed null check

    @tmayoff
    tmayoff committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    0fd6e2c View commit details
    Browse the repository at this point in the history

  5. Added -lc++11 to test .mpc file

    @tmayoff
    tmayoff committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    7f2a42a View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. Add '.value()' to strings

    @tmayoff
    tmayoff committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    03fd220 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'optional' of github.com:tmayoff/OpenDDS into optional

    @tmayoff
    tmayoff committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    af94ba7 View commit details
    Browse the repository at this point in the history

  3. Removed include

    @tmayoff
    tmayoff committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    a7e25e9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    dae3a07 View commit details
    Browse the repository at this point in the history

  5. Moved '.value()' gen

    @tmayoff
    tmayoff committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    067c2db View commit details
    Browse the repository at this point in the history

  6. Merge branch 'optional' of github.com:tmayoff/OpenDDS into optional

    @tmayoff
    tmayoff committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    74ad061 View commit details
    Browse the repository at this point in the history

  7. null check

    @tmayoff
    tmayoff committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    72762e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    6525ac2 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Updated mpc build for optional tests

    @tmayoff
    tmayoff committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    e8ba3f7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'optional' of github.com:tmayoff/OpenDDS into optional

    @tmayoff
    tmayoff committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    0e9feb6 View commit details
    Browse the repository at this point in the history

  3. Find and replace -Config CXX11 with -Config CXX11 -Config CXX17

    @tmayoff
    tmayoff committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    da6d465 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Removed IDL_Files

    @tmayoff
    tmayoff committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    6fbb6d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Removed or fixed CXX17 from CI tests

    @tmayoff
    tmayoff committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a15d02a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    99f556e View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Merge branch 'main' into optional

    @tmayoff
    tmayoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ddd5693 View commit details
    Browse the repository at this point in the history

  2. Readded deserialize check

    @tmayoff
    tmayoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    31dbf1f View commit details
    Browse the repository at this point in the history

  3. Fixed mpc builds

    @tmayoff
    tmayoff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    103558f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    47412a6 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Addressed some review comments

    @tmayoff
    tmayoff committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    985f630 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'optional' of github.com:tmayoff/OpenDDS into optional

    @tmayoff
    tmayoff committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    9801a28 View commit details
    Browse the repository at this point in the history

  3. Addressed some more review comments

    @tmayoff
    tmayoff committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    14fdcea View commit details
    Browse the repository at this point in the history

  4. Fixed formatting

    @tmayoff
    tmayoff committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    e8e7bea View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Fixed XcdrValueWriter

    @tmayoff
    tmayoff committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    3234f7d View commit details
    Browse the repository at this point in the history

  2. Formatting

    @tmayoff
    tmayoff committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    00c7e95 View commit details
    Browse the repository at this point in the history

  3. Added begin/end _optional to PrinterValueWriter in a test

    @tmayoff
    tmayoff committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    920cef2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    e0805a0 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    475eaa3 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Sinplified value_writer generation

    @tmayoff
    tmayoff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    cb93a19 View commit details
    Browse the repository at this point in the history

  2. Formatted

    @tmayoff
    tmayoff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    05eb15a View commit details
    Browse the repository at this point in the history

  3. Removed being_optional from PrinterValueWriter

    @tmayoff
    tmayoff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    0e485ca View commit details
    Browse the repository at this point in the history

  4. Discard changes to dds/DCPS/PrinterValueWriter.h

    @tmayoff
    tmayoff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d659623 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    0d6cdee View commit details
    Browse the repository at this point in the history

  2. Fixed tests and started with vread

    @tmayoff
    tmayoff committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    48f9d57 View commit details
    Browse the repository at this point in the history

  3. Cleanup some optional handling

    @tmayoff
    tmayoff committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    07e4664 View commit details
    Browse the repository at this point in the history

  4. fixed formatting

    @tmayoff
    tmayoff committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    df12b8d View commit details
    Browse the repository at this point in the history

  5. Fixed vread generation

    @tmayoff
    tmayoff committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    67f94d9 View commit details
    Browse the repository at this point in the history

  6. Remove include

    @tmayoff
    tmayoff committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    05e1afc View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Cleanup and improve the vread for optionals

    @tmayoff
    tmayoff committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8ae3dbd View commit details
    Browse the repository at this point in the history

  2. Remove test REQUIRE_TRUE(false)

    @tmayoff
    tmayoff committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    7b018ed View commit details
    Browse the repository at this point in the history

  3. Removed unused functions

    @tmayoff
    tmayoff committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    25678f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Formatted

    @tmayoff
    tmayoff committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    185adad View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Removed duplicate temporary values

    @tmayoff
    tmayoff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    47e284e View commit details
    Browse the repository at this point in the history

  2. Fixed the member_has_value wrapping

    @tmayoff
    tmayoff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    eb32ce4 View commit details
    Browse the repository at this point in the history

  3. Fixed formatting

    @tmayoff
    tmayoff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    66f63c5 View commit details
    Browse the repository at this point in the history

  4. Fixed struct compilation

    @tmayoff
    tmayoff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    bf2b132 View commit details
    Browse the repository at this point in the history

  5. Updated test

    @tmayoff
    tmayoff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    9b384a8 View commit details
    Browse the repository at this point in the history

  6. Removed comments in .idl file

    @tmayoff
    tmayoff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    96118fd View commit details
    Browse the repository at this point in the history

  7. Cleanup comments, and uneeded changes

    @tmayoff
    tmayoff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    be21157 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    68e3d06 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Fix .gitignore

    @tmayoff
    tmayoff committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8004336 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Merge branch 'refs/heads/main' into optional

    @tmayoff
    tmayoff committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1a22b27 View commit details
    Browse the repository at this point in the history

  2. Fixed merge issues

    @tmayoff
    tmayoff committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d659e7f View commit details
    Browse the repository at this point in the history

  3. Remove commented out merge conflict

    @tmayoff
    tmayoff committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4e86f11 View commit details
    Browse the repository at this point in the history

  4. minor cleanup

    @tmayoff
    tmayoff committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    97c8f42 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Merge branch 'master' into optional

    @tmayoff
    tmayoff committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    cde05d0 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge remote-tracking branch 'upstream/master' into optional

    @jrw972
    jrw972 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4ede16e View commit details
    Browse the repository at this point in the history

  2. Fix bugs in value_*_generator.cpp

    @jrw972
    jrw972 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    db857d4 View commit details
    Browse the repository at this point in the history

  3. Fixed KeyOnly tests

    @tmayoff
    tmayoff committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    82017fd View commit details
    Browse the repository at this point in the history

  4. Optional non KeyOnly structs use the "tmp" variable rather than

    @tmayoff
    tmayoff committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0e2c272 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'main' into optional

    @tmayoff
    tmayoff committed May 9, 2024
    Configuration menu
    Copy the full SHA
    82d06a6 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Fixed cmake CXX_STD year, and gtest EXPECT_EQ macros

    @tmayoff
    tmayoff committed May 10, 2024
    Configuration menu
    Copy the full SHA
    68f5f80 View commit details
    Browse the repository at this point in the history

  2. Fixed lint issue

    @tmayoff
    tmayoff committed May 10, 2024
    Configuration menu
    Copy the full SHA
    d574746 View commit details
    Browse the repository at this point in the history

  3. linting issue again

    @tmayoff
    tmayoff committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e64c915 View commit details
    Browse the repository at this point in the history

  4. linted, for real this time. ran script locally

    @tmayoff
    tmayoff committed May 10, 2024
    Configuration menu
    Copy the full SHA
    aac7634 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge remote-tracking branch 'upstream/master' into optional

    @jrw972
    jrw972 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    af968cf View commit details
    Browse the repository at this point in the history

  2. Fix build errors

    @jrw972
    jrw972 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    08ac017 View commit details
    Browse the repository at this point in the history

  3. Remove test

    @jrw972
    jrw972 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    93e9d28 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Integrate test into xcdr test

    @jrw972
    jrw972 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    7bfb2d8 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Merge pull request #7 from jrw972/optional-integration

    @tmayoff
    tmayoff committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5ea4b4a View commit details
    Browse the repository at this point in the history

  2. Remove the add_subdirectory for the now moved optional tests

    @tmayoff
    tmayoff committed May 24, 2024
    Configuration menu
    Copy the full SHA
    fb7a2d7 View commit details
    Browse the repository at this point in the history

  3. Readd boolean edgecase

    @tmayoff
    tmayoff committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b1a68dc View commit details
    Browse the repository at this point in the history

  4. Use OPENDDS_OPTIONAL_NS

    @tmayoff
    tmayoff committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0885928 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Fixed optional include

    @tmayoff
    tmayoff committed May 25, 2024
    Configuration menu
    Copy the full SHA
    897ee02 View commit details
    Browse the repository at this point in the history

  2. Replace std::nullopt with {} for the default value

    @tmayoff
    tmayoff committed May 25, 2024
    Configuration menu
    Copy the full SHA
    043c46b View commit details
    Browse the repository at this point in the history

  3. Add nullopt implementation, this may not work for C++ less than C++11

    @tmayoff
    tmayoff committed May 25, 2024
    Configuration menu
    Copy the full SHA
    6a0d3f9 View commit details
    Browse the repository at this point in the history

  4. removed constexpr

    @tmayoff
    tmayoff committed May 25, 2024
    Configuration menu
    Copy the full SHA
    abcdc68 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Maybe fixed the nullopt

    @tmayoff
    tmayoff committed May 27, 2024
    Configuration menu
    Copy the full SHA
    f3f28f8 View commit details
    Browse the repository at this point in the history

  2. const ref nullopt constructor

    @tmayoff
    tmayoff committed May 27, 2024
    Configuration menu
    Copy the full SHA
    81cfbf9 View commit details
    Browse the repository at this point in the history

  3. Remove nullopt and just default construct the optional

    @tmayoff
    tmayoff committed May 27, 2024
    Configuration menu
    Copy the full SHA
    2077b6d View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Fix integration issues

    @jrw972
    jrw972 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1d8c53c View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Fixes for DynamicData implementations

    @jrw972
    jrw972 committed May 30, 2024
    Configuration menu
    Copy the full SHA
    64274a3 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Fix bad access

    @jrw972
    jrw972 committed May 31, 2024
    Configuration menu
    Copy the full SHA
    e905ac9 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Add news fragment for optional, and updated the docs removing optiona… 

    …l as unimplemented and some docs what the annotation does (It seems quite self-explanatory so wasn't really sure what to write)
    @tmayoff
    tmayoff committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0317ecc View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Remove -Config CXX17

    @jrw972
    jrw972 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    7fa6c88 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Adam Mitz <mitza@objectcomputing.com>
Co-authored-by: Fred Hornsey <fred@hornsey.us>
    @tmayoff @mitza-oci @iguessthislldo
    3 people committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8ec4721 View commit details
    Browse the repository at this point in the history

  3. Resolved some review comments

    @tmayoff
    tmayoff committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    550e85a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'optional' of github.com:tmayoff/OpenDDS into optional

    @tmayoff
    tmayoff committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8f215bd View commit details
    Browse the repository at this point in the history