Test Making RTPS the Default for the Future #2454
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the default discovery is InfoRepo and the default transport is tcp when not using safety profile. This attempts to change the default discovery to rtps and the default transport to rtps_udp. This is commit is to show the initial progress and see the tests run in CI over a wider set of configurations. Locally tests run, but a lot of them fail, so this defiantly needs more work.
|
Additional context for this one... It's a draft PR because we don't intent to merge it in the near term. We're testing the changes here to learn what would be required to make the changes for a future version. |
iguessthislldo
changed the title
|
That's a good point that I left out. I put something to that effect in the commit message, but left that out of the PR description for some reason. Changed the PR name to more accurately reflect this. |
iguessthislldo
changed the title
|
I can support this for 100%, RTPS should be the default. |
I don't know when this is going to get merged, so I should put this changes somewhere else.
This doesn't change all tests that need changing, just a few that look like they explicitly test the info repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when not using safety profile, the default discovery is InfoRepo and the default transport is tcp. This attempts to change the default discovery to rtps and the default transport to rtps_udp.