Added code to show get_instance_handles() and lookup_instance() #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are all the changes here necessary to demonstrate the problem described in #1641? If the overall test design needs to change, please also update the README in the same directory. It seems like the next step would be to make the test fail when it encounters this problem. Also remove nullptr so it will compile on all supported compilers. |
|
Yes, it will demonstrate the problem.
I’ll change nullptr back to NULL.
I was hesitant to make the test fail … just wanted to show problem.
|
|
Did I use nullptr somewhere?
I thought perhaps I did out of habit, but I don’t see it in the files I checked in.
|
|
Oh duh, nevermind … was on wrong branch
|
|
Closing this pull request as there are currently no plans for fixing persistence using the current architecture. The issue that links to this pull request will stay open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are only to tests/DCPS/PersistentDurability. These changes do not cause the test to fail, they only help illustrate issue 1641.
They show that, after persistent messages are read into a DataWriter, those messages do not appear correctly when using get_instance_handles() and get_key_value(). Nor can lookup_instance() find anything using known key values.