New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishers.Merge #72
base: master
Are you sure you want to change the base?
Publishers.Merge #72
Conversation
93f9189
to
a279ff4
Compare
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
- Coverage 98.22% 90.89% -7.34%
==========================================
Files 83 72 -11
Lines 4562 3908 -654
==========================================
- Hits 4481 3552 -929
- Misses 81 356 +275
Continue to review full report at Codecov.
|
a279ff4
to
2b047d2
Compare
2b047d2
to
af0ae86
Compare
[.subscription("Merge")] + expectedValues) | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 Limit vertical whitespace to a single empty line. Currently 2. (
vertical_whitespace
)
Does it suspend? |
What's the status on this pull request? I need |
It's been 2 years since this issue was opened, is there any intent for you guys to work on it? |
There is intent, but none of the maintainers had free time to work on this issue. New pull requests that implement a corresponding test suite and make it pass are always welcome and I'd be happy to review them. |
For anyone interested on this topic: But it has some dependency here. (eg. #248 as I do not intend to support that old version of Swift) If the upstream feels good about it and someone can help review it, I can open a pull request here. |
Publishers.MergeMany
!ManagedBuffer
?