New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CombineLatest #119
base: master
Are you sure you want to change the base?
Conversation
broadwaylamb
commented
Dec 10, 2019
•
edited
edited
- Add tests
- Update documentation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 97.70% 95.26% -2.44%
==========================================
Files 100 102 +2
Lines 6921 7098 +177
==========================================
Hits 6762 6762
- Misses 159 336 +177
Continue to review full report at Codecov.
|
LGTM Generated by 🚫 Danger Swift against 26e86a9 |
02a08d5
to
92417da
Compare
92417da
to
a9fc1f3
Compare
a9fc1f3
to
c2ae159
Compare
c2ae159
to
26e86a9
Compare
@broadwaylamb @devmaximilian anything I could do to help with getting this merged? Is it just tests missing at this point? We're looking to migrate from ReactiveSwift to Combine (and OpenCombine) and this is sort of a missing piece for us. |
@robertjpayne I have processed on this PR and completed the missing part on my fork recently. You can give it a try if you are still interested - OpenSwiftUIProject#16 |