Fix the problem of not checking if attr exists for cpg #10286

Dango233 · 2023-05-25T16:31:39Z

When load network saved using previous version of oneflow, as the cpg attribute not exist, the self.cpg reference will fail.
PR address this problem by adding an additional layer of check.

strint · 2023-05-26T01:48:15Z

python/oneflow/nn/modules/module.py

-                "apply operations like to(), to_global() will cause error."
-            )
+        if hasattr(self, "cpg"):
+            if self.cpg is not None:


两个 if 可以合并成一行

Fix the problem of not checking if attr exists

65405fd

Dango233 requested review from BBuf and daquexian as code owners May 25, 2023 16:31

strint reviewed May 26, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the problem of not checking if attr exists for cpg #10286

Fix the problem of not checking if attr exists for cpg #10286

Dango233 commented May 25, 2023

strint May 26, 2023

Fix the problem of not checking if attr exists for cpg #10286

Are you sure you want to change the base?

Fix the problem of not checking if attr exists for cpg #10286

Conversation

Dango233 commented May 25, 2023

strint May 26, 2023

Choose a reason for hiding this comment