Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: remove refs to deprecated io/ioutil #309

Merged
merged 3 commits into from May 13, 2024
Merged

Conversation

testwill
Copy link
Contributor

PR Introduction

First of all, thank you for considering to raise a pull request!

Don’t be afraid to ask for advice before working on a contribution. If you’re thinking about a bigger change, especially that might affect the core working or architecture, it’s almost essential to talk and ask about what you’re planning might affect things. Some of the larger future plans may not be documented well so it’s difficult to understand how your change might affect the general direction and roadmap of this project without asking.

The preferred way to communicate is probably via Discord or GitHub issues.

Helpful information to understand the project can be found here: CONTRIBUTING

^^^ please delete the lines above when raising a PR to keep the request to the bare essentials ^^^

Checklist

Please put a X in the boxes as evidence of reading through the checklist.

  • I have forked the project, and raised this PR on a feature branch.
  • make githooks has been run, and my git commit message was accepted by the git hook.
  • make daemon-compile runs without any issues.
  • make daemon-codestyle runs without any issues.
  • make daemon-unittests runs without any issues.
  • make webui-codestyle runs without any issues.
  • I understand and accept the AGPL-3.0 license and code of conduct, and my contributions fall under these.

@jamesread
Copy link
Collaborator

@testwill Hey, thanks so much for your first contribution to OliveTin! I'm really curious, what made you go find this issue, and fix it? Were you working on something else you'd like help with?

Your changes look absolutely fine - I had no idea that ioutil was deprecated, and I love getting rid of additional dependencies. Many thanks.

I'll run the tests and merge as long as they succeed (unlikely to have any issues).

@jamesread jamesread changed the title chore: remove refs to deprecated io/ioutil fmt: remove refs to deprecated io/ioutil May 13, 2024
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
@testwill
Copy link
Contributor Author

@testwill Hey, thanks so much for your first contribution to OliveTin! I'm really curious, what made you go find this issue, and fix it? Were you working on something else you'd like help with?

Your changes look absolutely fine - I had no idea that ioutil was deprecated, and I love getting rid of additional dependencies. Many thanks.

I'll run the tests and merge as long as they succeed (unlikely to have any issues).

staticcheck

@jamesread
Copy link
Collaborator

@testwill Nice, I just tried staticcheck and that gives me a few new things to look at.

What made you decide to run staticcheck against OliveTin? Just re-running tests after the force-push.

@jamesread jamesread enabled auto-merge May 13, 2024 13:13
@jamesread jamesread added this pull request to the merge queue May 13, 2024
Merged via the queue into OliveTin:main with commit 7e34efd May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants