Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPXS <1.8 multiplate Flex bugfix #340

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kathy-nevola
Copy link
Contributor

@kathy-nevola kathy-nevola commented Mar 18, 2024

Title: Support for wide format multiplate flex data (pre-NPXS 1.8)

Problem: Wide format Flex data (pre NPXS 1.8 which should be supported) was not working with read_NPX in multiplate projects

Solution: Two bugs were found and addressed in read_flex:

  • When filtering out metadata (line 153) in the paste call, collapse was changed to sep (line 161) to correctly form the logical argument.
  • When joining the per assay meta data, plateID was included as a merging column as some assay meta data differs between plates (line 166)

Checklist

  • Make sure you are requesting to pull a feature/bugfix branch (right side). This should not be main or develop.
  • Make sure you are make a pull request against either main or develop (left side). (Requesting to main should be reserved for bugfixes and new releases)
  • Add or update unit tests (if applicable)
  • Check your code with any unit tests (Run devtools::check() locally)
  • Add neccessary documentation (if applicable)

Type of changes

What type of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue) (link the issue on the right)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Documentation Update
  • Other (explain)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, any questions you have, etc...

Consider linking any issues (#issue-number ) or adding @mentions to ensure specific people see it.

@kathy-nevola kathy-nevola changed the base branch from main to develop March 18, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant