Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Exchange2013 to the enum #547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yiyangli-okta
Copy link

Hi, there, this is Yiyang Li, from Okta. I am forking the project because I need to implement InstallAppRequest and InstallAppResponse by copying codes from EWS Managed API. Since the minimum version of InstallApp is 2013, could you please add this enum?

Thanks.

Yiyang Li

Hi, there, this is Yiyang Li, from Okta. I am forking the project because I need to implement InstallAppRequest and InstallAppResponse by copying codes from EWS Managed API. Since the minimum version of InstallApp is 2013, could you please add this enum? 

Thanks. 

Yiyang Li
@codecov-io
Copy link

Current coverage is 10.43% (diff: 100%)

No coverage report found for master at 7f8793a.

Powered by Codecov. Last update 7f8793a...4a196c3

@serious6
Copy link
Member

serious6 commented Oct 8, 2016

once there is specific code integrated that will make use of the "new version" we should add more exchange versions to the enum but until that time I do not see a specific need for it since it does not provide further features?!

Copy link
Member

@serious6 serious6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See additional comment

@yiyangli-okta
Copy link
Author

yiyangli-okta commented Oct 18, 2016

hi, @serious6, could you take a look at this PR?

#550

is this one of the specific needs? I really like the InstallAppRequest, it helps our company to integrate office 365 suite with other 3rd party better -- so that users don't need to enable apps in app store.

Could you review the PR when you have time? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants