Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UseDefaultCredentials Option #517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LukeWage
Copy link

Allow Integrated Windows Authentication to be used when authenticating
to the Exchange server.

I apologize in advance if any part of this pull request is improper. I am very inexperienced with Online Collaboration. I considered creating a JUnit test for the new functionality but I didn't know how I could test the code without a server to contact. I tried to minimize the impact of this code so it only affects users who have enabled the UseDefaultCredentials feature. I disabled it by default to mirror the .NET API.

Allow Integrated Windows Authentication to be used when authenticating
to the Exchange server.
@azurecla
Copy link

Hi @LukeWage, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@codecov-io
Copy link

Current coverage is 10.42%

Merging #517 into master will decrease coverage by -0.01% as of cac2222

@@            master    #517   diff @@
======================================
  Files          550     550       
  Stmts        20436   20442     +6
  Branches      2626    2629     +3
  Methods          0       0       
======================================
  Hit           2132    2132       
- Partial        153     154     +1
- Missed       18151   18156     +5

Review entire Coverage Diff as of cac2222

Powered by Codecov. Updated on successful CI builds.

@azurecla
Copy link

@LukeWage, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, AZPRBOT;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants