Issue #497: Allow socket timeout to be overridden on a per request basis #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equest basis. This allows the GetStreamingEvents call to specify a longer timeout so connection is not dropped before lifetime minutes has been reached. Relying on heartbeats to keep the connection alive does not seem to work for Office365.
Current coverage is
|
| @@ -122,6 +125,10 @@ protected void validate() throws Exception { | |||
| this.service.validate(); | |||
| } | |||
|
|
|||
| public void setTimeout(Integer timeout) { | |||
There was a problem hiding this comment.
please add javadoc to this method
|
once javadocs has been added this is ready to merge. Fell free to add some unit-tests as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the GetStreamingEvents call to specify a longer timeout so connection is not
dropped before lifetime minutes has been reached. Relying on heartbeats to keep the
connection alive does not seem to work for Office365.