Add option to use tcp_nodelay in tentacle, also use the option in integration tests. #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeButters
changed the base branch from
main
to
luke/tests-use-single-halibut-limits-config
LukeButters
force-pushed
the
luke/add-option-to-use-tcpnodelay
branch
from
b512fdd
to
62484b9
Compare
Base automatically changed from
luke/tests-use-single-halibut-limits-config
to
main
May 17, 2024 04:40
LukeButters
force-pushed
the
luke/add-option-to-use-tcpnodelay
branch
from
97310e9
to
fa9a600
Compare
LukeButters
changed the title
LukeButters
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Background: https://brooker.co.za/blog/2024/05/09/nagle.html
TLDR; TCP_NODELAY=true results in much faster for RPC performance in linux. TCP_NODELAY disables a TCP setting that makes sense when humans type characters into telnet (buffer the chars before sending because humans are slow) but less sense in halibut since when we send a thing we actually would like it to go over the wire now.
This PR adds an option to use: OctopusDeploy/Halibut#610
Additionally TCP_NODELAY is used by default in tests.
[SC-76274]
How to review this PR
Quality ✔️
Pre-requisites