Update to Kubernetes SDK 14 and add new test #931
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flin-8
reviewed
May 16, 2024
source/Octopus.Tentacle.Kubernetes.Tests.Integration/KubernetesClusterOneTimeSetUp.cs
Outdated
Show resolved
Hide resolved
flin-8
reviewed
May 16, 2024
| var finalPodName = commandResult.StdOut.Single(); | ||
|
|
||
| //Assert | ||
| logs.Should().Contain(po => po.Source == ProcessOutputSource.StdOut && po.Text == "Hello World"); |
There was a problem hiding this comment.
Is it possible to also assert that Halibut got an error and is retrying mid way through the script?
There was a problem hiding this comment.
I actually don't think this test is working correctly. I may need to tweak the script so that it waits until the old pod is dead (or something like that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The Kubernetes C# SDK that supports Kubernetes 1.30 has been released
This PR updates the package references and also adds a new integration test which tests what happens when the tentacle pod is killed midway through a script.
Results
Adds a new
KubeCtlToolclass that is used for interacting with KubeCtl. I think eventually this will have named methods likeDeletePodetcWe will also need to update the documentation to indicate that v1.30 is a supported Kubernetes version
How to review this PR
Quality ✔️
Pre-requisites