Port TraceLogFileLogger from Halibut #750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
|
|
||
| [assembly: SuppressMessage("Style", "VSTHRD200:Use \"Async\" suffix for async methods", Justification = "Test code")] |
There was a problem hiding this comment.
Referencing added some additional code analysis
| var testName = ""; | ||
| if (TeamCityDetection.IsRunningInTeamCity()) | ||
| var testName = TestContext.CurrentContext.Test.FullName; | ||
| var testHash = CurrentTestHash(); |
There was a problem hiding this comment.
Ported the TestHash with this change as well as it's a good change to reduce log line length
LukeButters
approved these changes
Dec 19, 2023
LukeButters
reviewed
Dec 19, 2023
| var currentDirectory = Directory.GetCurrentDirectory(); | ||
| var rootDirectory = new DirectoryInfo(currentDirectory).Parent!.Parent!.Parent!.Parent!.Parent!; | ||
|
|
||
| var traceLogsDirectory = rootDirectory.CreateSubdirectory("artifacts").CreateSubdirectory("trace-logs"); |
There was a problem hiding this comment.
I think we will need to tell teamcity to capture this directory as an artifact.
There was a problem hiding this comment.
Is that done in the team city build configuration?
There was a problem hiding this comment.
Yep
+:artifacts/trace-logs/**/* => trace-logs
in each build config
nathanwoctopusdeploy
force-pushed
the
sast/port-TraceLogFileLogger-from-Halibut
branch
from
937583f
to
bbe19b3
Compare
nathanwoctopusdeploy
force-pushed
the
sast/port-TraceLogFileLogger-from-Halibut
branch
from
bbe19b3
to
c1eb30a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Port TraceLogFileLogger from Halibut
How to review this PR
Quality ✔️
Pre-requisites