dotnet-script use local tool #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with bundled version
| @@ -21,7 +22,8 @@ public void DotnetScript_CSharpDecryptsVariables() | |||
| var variables = GetVariables(); | |||
| variables.Add(ScriptVariables.UseDotnetScript, bool.TrueString); | |||
| File.WriteAllText(scriptFile.FilePath, "System.Console.WriteLine(OctopusParameters[\"mysecrect\"]);"); | |||
| var result = ExecuteScript(new DotnetScriptExecutor(), scriptFile.FilePath, variables); | |||
| var commandLineRunner = new TestCommandLineRunner(new InMemoryLog(), new CalamariVariables()); | |||
| var result = ExecuteScript(new DotnetScriptExecutor(commandLineRunner), scriptFile.FilePath, variables); | |||
There was a problem hiding this comment.
I tried testing this, including a bundled dotnet-script package, extracting that to a path, and adding that path to the environment variables. In the test context this was not retrieving the executable path on the where/which commands. I sunk a lot of time into this and couldn't work out why this wasn't working.
IsaacCalligeros95
changed the title
| @@ -67,7 +67,8 @@ public async Task InstallTerraform() | |||
|
|
|||
| await DownloadTerraform(fileName, client, tuple.data, destinationDirectoryName); | |||
|
|
|||
| var terraformExecutable = Directory.EnumerateFiles(destinationDirectoryName).FirstOrDefault(); | |||
| var terraformExecutable = Directory.EnumerateFiles(destinationDirectoryName) | |||
There was a problem hiding this comment.
Fixes test issues
| Initialize-AzureRmContext | ||
| } | ||
| else { | ||
| if($OctopusAzureRMIsDepreciated -like [Boolean]::TrueString) { |
There was a problem hiding this comment.
@rain-on I've inverted the check here for the sake of the tests. I can't see this changing any other behaviour but just wanted to raise this incase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for using a locally installed version of dotnet-script. Execution uses in order:
where/whichDeprecation warning
Note logs include additional logging for debugging purposes these lines are not included in the final PR.
dotnet-script tool installed on WSL Bash script
WSL container without dotnet-script on path
WSL executing dotnet-script file
dotnet-script tool installed on Windows .cmd on path
dotnet-script tool installed on Windows .exe on path
No dotnet-script tool installed on Windows (bundled)
