Add proxies for Azure Clients #1168
Conversation
IsaacCalligeros95
force-pushed
the
isaac/add-az-proxies
branch
from
fbac30c
to
7c23c04
Compare
…ent setters are provided
IsaacCalligeros95
force-pushed
the
isaac/add-az-proxies
branch
from
7c23c04
to
44e6351
Compare
|
|
||
| namespace Calamari.AzureCloudService | ||
| { | ||
| public class AuthHttpClientFactory |
There was a problem hiding this comment.
Do we need this duplicated?
There was a problem hiding this comment.
It's duplicated in this LTS branch but has been consolidated into Azure.CloudAccounts in master and is shared from there. As this is just the case for this LTS branch I wasn't too phased adding the additional class, it's what is there currently.
| @@ -169,8 +172,8 @@ public async Task Deploy_Ensure_Tools_Are_Configured() | |||
| { | |||
| var serviceName = $"{nameof(DeployAzureCloudServiceCommandFixture)}-{Guid.NewGuid().ToString("N").Substring(0, 12)}"; | |||
| var deploymentSlot = DeploymentSlot.Staging; | |||
|
|
|||
| using var client = new ComputeManagementClient(subscriptionCloudCredentials); | |||
| var httpClientProxy = new AuthHttpClientFactory().GetHttpClient(); | |||
There was a problem hiding this comment.
It seems there is some inconsistency in how we get the client:
new AuthHttpClientFactory().GetHttpClient()AuthHttpClientFactory.ProxyClientHandler()
How would someone know which to use?
There was a problem hiding this comment.
The ComputeManagementClient only takes a httpClient while others take a httpClientHandler. the httpClientHandler looks to be the way moving forward.
| // Note we aren't using Alphaleonis.Win32.Filesystem.Directory.EnumerateFiles which handles long file paths due to performance issues. | ||
| var parentDirectoryInfo = new DirectoryInfo(parentDirectoryPath); | ||
|
|
||
| return searchPatterns.Length == 0 | ||
| ? Alphaleonis.Win32.Filesystem.Directory.EnumerateFiles(parentDirectoryPath, "*", searchOption) | ||
| : searchPatterns.SelectMany(pattern => | ||
| Alphaleonis.Win32.Filesystem.Directory.EnumerateFiles(parentDirectoryPath, pattern, searchOption)); | ||
| ? parentDirectoryInfo.GetFiles("*", searchOption).Select(fi => fi.FullName) | ||
| : searchPatterns.SelectMany(pattern => parentDirectoryInfo.GetFiles(pattern, searchOption).Select(fi => fi.FullName)); |
There was a problem hiding this comment.
This seems unrelated, should it be removed?
Done, merged the latest for release/2023.3 |
This extends the addition of proxies in #1133 and #1149 to all Azure clients excluding ServiceFabric where our current version does not support adding httpClients or handlers.