Support Azure OIDC testing #1127
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g Assembly reference to a unique class
…ove token exchange from AzureScripting
…loy/Calamari into isaac/azure-oidc-auth
…loy/Calamari into isaac/azure-oidc-auth
veochen-octopus
force-pushed
the
veo/oidc-test
branch
from
db676d1
to
80d6d1d
Compare
This reverts commit ddf9396.
veochen-octopus
commented
Sep 22, 2023
| @@ -44,7 +44,7 @@ function setup_context { | |||
|
|
|||
| if [ -n $Octopus_Open_Id_Jwt ] | |||
| then | |||
| echo "Azure CLI: Authenticating with OpenID Connect Access Token" | |||
| echo "Azure CLI: Authenticating with OpenID Connect Federated Token" | |||
There was a problem hiding this comment.
Changing this to be consistent with the other messages.
veochen-octopus
commented
Sep 22, 2023
Comment on lines
+39
to
+40
| ? await (account as AzureOidcAccount).GetAuthorizationToken(CancellationToken.None) | ||
| : await (account as AzureServicePrincipalAccount).GetAuthorizationToken(); |
There was a problem hiding this comment.
Simplifies the method calls. Also makes it easier for the discovery endpoint to travel downstream.
veochen-octopus
force-pushed
the
veo/oidc-test
branch
from
c3e65df
to
b2380c9
Compare
This reverts commit 6cbe7bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 main things:
Also some minor code improvements I found along the way.