Make KOS able to handle resources without namespaces #1114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
yihao/fix-no-namespace
branch
from
6b9b157
to
59cea76
Compare
ghost
commented
Aug 29, 2023
|
|
||
| // Filter out cluster-wide resources | ||
| definedResources = definedResources | ||
| .Where(resource => !string.IsNullOrEmpty(resource.Namespace) && !nonNamespacedDefinedResources.Contains(new ResourceIdentifier(resource.Kind, resource.Name, string.Empty))) |
There was a problem hiding this comment.
If either the namespace on the identifier itself is empty, or the namespace from the resource response is empty, we consider it cluster-scoped.
The namespace on the identifier itself can be empty if the identifier is created by parsing the response of an apply command directly, which is the case when using batch apply with glob patterns.
ghost
force-pushed
the
yihao/fix-no-namespace
branch
from
115ee96
to
78b4ce6
Compare
ghost
force-pushed
the
yihao/fix-no-namespace
branch
from
78b4ce6
to
62627c8
Compare
|
Yihao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes customers need to deploy resources that are cluster-scoped, which do not have namespaces. Currently these resources result in a
kubectl get <kind> <name> -ncommand being sent, which is invalid because the namespace argument-nmust have a value.This PR fixes this issue by filtering out the resources that are cluster-scoped. When we have cluster-scoped resources, we exclude them from the KOS and do not show them to the customer. Instead we note them down in the task log, and tell the customer that those are not checked against.
Assuming we are using this YAML which deploys a cluster-scoped resource:
Before
After