Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include rejection of time step if tolerance test fails #5317

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Include rejection of time step if tolerance test fails #5317

wants to merge 4 commits into from

Commits on Apr 26, 2024

  1. Fixed indexing error in PID controller

    @erikhide
    erikhide committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    3c45e2a View commit details
    Browse the repository at this point in the history

  2. Added errors_[0] == 0 to conditional

    @erikhide
    erikhide committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ee8e4be View commit details
    Browse the repository at this point in the history

  3. If the error/relative change after a time step is too large, the simu… 

    …lation now rejects the time step and tries again with a shorter time step
    @erikhide
    erikhide committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e4d7806 View commit details
    Browse the repository at this point in the history

  4. Removed time step cutting in the PID controller implementation, since… 

    … this is now done in AdaptiveTimeStepping.hpp, including a rejection of the time step
    @erikhide
    erikhide committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5331627 View commit details
    Browse the repository at this point in the history