-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the PYTHONPATH for the tests using python #5306
Conversation
…t should have been there before actually
jenkins build this please |
4a55b78
to
20a8f67
Compare
jenkins build this please |
jenkins build this opm-common=4017 please |
20a8f67
to
fd2daa2
Compare
jenkins build this please |
1 similar comment
jenkins build this please |
CMakeLists.txt
Outdated
|
||
if(opm-common_EMBEDDED_PYTHON) | ||
set_target_properties(flow PROPERTIES | ||
ENVIRONMENT "PYTHONPATH=${PROJECT_BINARY_DIR}/python:${opm-common_DIR}/python:$ENV{PYTHONPATH}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes little sense. you cannot set the environment for an executable, only on a test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks! That explains why that has no effect.. I also tried setting the environment variable in the shell script that execute the failing tests: fd2daa2, but that also did not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i just checked it and that code does the intended job at least.
fd2daa2
to
ba88e2c
Compare
python/simulators/CMakeLists.txt
Outdated
COMMAND ${PYTHON_EXECUTABLE} "${PYTHON_INSTALL_PY}" | ||
${PROJECT_SOURCE_DIR}/python/opm_embedded ${PROJECT_BINARY_DIR}/python 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to fail as there is no opm_embedded on my system
jenkins build this please |
…e it to set the PYTHONPATH for the tests using python
ba88e2c
to
3f5d14d
Compare
jenkins build this please |
The pipeline on OPM/opm-common#4017 actually runs through without this change, closing it |
Add argument 'ENVIRONMENT' to add_test_compareSeparateECLFiles and use it to set the PYTHONPATH for the tests using python