New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report CNV Violation Pore-Volume Fraction to INFOITER #5302
Conversation
As an example of the change, here is an excerpt from Current Master Sources
This PR
|
jenkins build this please |
jenkins build this please |
I think it would be easier for existing scripts etc. if we add the new column at the end instead of the beginning. Otherwise this is fine! Would like to add some more detailed output though: fraction of pore volume with each of {CNV > ToleranceCnvRelaxed, CNV > ToleranceCnv, [possibly more detailed as well to build a histogram]} as well as number of grid cells for each. That can be done in a followup though. |
Maybe, but in that case I'm inclined to label those scripts "poorly written". I added it here because it's in a simple sequence of columns which will always be present whereas the other columns depend on the active phases and whether or not wells are active in the model.
Good idea
Sure. |
54de3a0
to
4d646f8
Compare
cdee128
to
bb06c55
Compare
The prerequisite PR #5307 was merged into the master branch. I'm marking this as "ready for review" once again and I'm running a build check. |
jenkins build this please |
This commit includes the fraction of pore-volume whose CNV targets are violated as a new per-iteration quantity in the INFOITER file (--output-extra-convergence-info=iteration), with the column header "CnvErrPvFrac". We collect the values which are already calculated in BlackoilModel<>::getReservoirConvergence() and store these as a pair of numerator and denominator in the ConvergenceReport class. Note that we need both the numerator and the denominator in order to aggregate contributions from multiple ranks. While here, also make a few more objects 'const' and calculate column widths directly instead of the maximum number of characters in writeConvergenceHeader().
jenkins build this please |
This commit includes the fraction of pore-volume whose CNV targets are violated as a new per-iteration quantity in the INFOITER file (
--output-extra-convergence-info=iteration
), with the column headerCnvErrPvFrac
. We collect the values which are already calculated inand store these as a pair of numerator and denominator in the
ConvergenceReport
class. Note that we need both the numerator and the denominator in order to aggregate contributions from multiple ranks.While here, also make a few more objects 'const' and calculate column widths directly instead of the maximum number of characters in
writeConvergenceHeader()
.