Add support for using float Scalars in simulators #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akva2
force-pushed
the
floats
branch
2 times, most recently
from
32680d7
to
7f4e4d8
Compare
This was referenced Apr 23, 2024
for some reason the cpu backend breaks. dunno why yet
UMFPack cannot handle floats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes necessary to support float Scalars.
Some TODOs left:
Runtime has been lightly tested with the BDA gpu solvers, opencl, cusparse and amgcl (vexcl and cuda backends) and dune cpu solvers. It seems to work although there is non-uniform results (opencl seems to do better than cusparse for some reason).
Do not ask for this to be merged in this shape. Commit topology is optimized to aid rebasing, not for sanity.