Allow empty partitions #4308
Draft
Allow empty partitions #4308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, then we will get a fix for #2770 if that still applies. |
all processes need to participate in the summation, even if they own no cells in the region.
if a process owns no cells, the pvt_region_idx_ vector is empty. in that case we use a dummy -1 value
this is not true if a process has zero cells -> not a logic error.
if matrix is empty, dividing by N() is not a good idea. this happens if a process owns zero cells
not entries to calculate. in particular zero'ing an empty matrix causes dune to throw
calling compress() on an empty matrix causes a nullptr dereference. use random build mode to avoid the call to compress() if matrix is empty.
we are using the local size to flag whether or not to store a field. this does not work if the process owns zero cells. we have to broadcast the enabled fields names from the first process owning cells to get this in sync on zero-cell processes.
akva2
force-pushed
the
allow_empty_partitions
branch
from
b6b77da
to
b0377b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing purposes (zoltan acting up), it was requested that flow can run with empty grid partitions. This is the start of that work.
Downstream of OPM/opm-grid#606