Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1.5 Salt Precipitation Model #42

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Update 1.5 Salt Precipitation Model #42

merged 1 commit into from
Jan 3, 2024

Conversation

gdfldm
Copy link
Collaborator

@gdfldm gdfldm commented Dec 20, 2023

Update Salt Precipitation Model description in section 1.5. This includes adding a description of the c_w^salt variable - possibly resolving issue #14.

Update Salt Precipitation Model description in section 1.5. This includes adding a description of the c_w^salt variable - possibly resolving issue #14.
@blattms
Copy link
Member

blattms commented Jan 3, 2024

Just two things (that where there before):

  • In the descriptions there is \rho_\alpha (density of he solid salt) which is used nowhere
  • Description of \rho^salt is "surface density of phase \alpha at one atmosphere, a given constant.", but there is no alpha

Should we try to fix these, too?

@blattms blattms merged commit 90e4ecc into OPM:main Jan 3, 2024
@blattms
Copy link
Member

blattms commented Jan 3, 2024

Merged anyway. Further changes should become a different PR:

blattms added a commit that referenced this pull request Jan 3, 2024
Added 1.7 Formation Damage Models (based on #42)
@gdfldm gdfldm deleted the 1-5--salt-precip branch January 31, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants