Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACF keyword as unsupported in 2024-04 #232

Merged
merged 1 commit into from May 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions keyword-names/8.3/keywords.txt
@@ -1,3 +1,4 @@
ACF
ADD
ADDREG
ADSALNOD
Expand Down Expand Up @@ -171,8 +172,8 @@ MASSFLOW
MAXVALUE
MESSAGE
MESSAGES
MINVALUE
MICPPARA
MINVALUE
MISC
MLANG
MLANGSLV
Expand Down Expand Up @@ -227,16 +228,16 @@ PVCO
PVDG
PVDO
PVDS
PVSOL
PVTG
PVTGW
PVTGWO
PVTO
PVSOL
PVTW
PVTWSALT
PVZG
PYEND
PYINPUT
PVZG
QHRATING
REFINE
RIVRXSEC
Expand Down Expand Up @@ -318,8 +319,8 @@ STONE1EX
STONE2
STOW
STWG
SURFADDW
SURF
SURFADDW
SURFCAPD
SURFESAL
SURFROCK
Expand Down
16 changes: 15 additions & 1 deletion parts/appendices/A.fodt
Expand Up @@ -6773,7 +6773,21 @@ Updated with AFR/TSA Rev-D comments and new keywords.</dc:description><meta:init
</table:table-cell>
</table:table-row>
</table:table-header-rows>
<table:table-row table:style-name="Table35.2">

<table:table-row table:style-name="AppendixA_TableRow">
<table:table-cell table:style-name="AppendixA_TableCell" table:number-columns-spanned="7" office:value-type="string">
<text:p text:style-name="_40_Table_20_Contents"><text:a xlink:type="simple" xlink:href="#0.0.0.ACF" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link"><text:bookmark-ref text:reference-format="text" text:ref-name="REF_HEADING_KEYWORD_ACF">ACF – Define Acentric Factors</text:bookmark-ref></text:a></text:p>
</table:table-cell>
<table:covered-table-cell></table:covered-table-cell>
<table:covered-table-cell></table:covered-table-cell>
<table:covered-table-cell></table:covered-table-cell>
<table:covered-table-cell></table:covered-table-cell>
<table:covered-table-cell></table:covered-table-cell>
<table:covered-table-cell></table:covered-table-cell>
<table:table-cell table:style-name="AppendixA_TableCell_Orange" office:value-type="string">
<text:p text:style-name="_40_Table_20_Contents"></text:p>
</table:table-cell>
</table:table-row><table:table-row table:style-name="Table35.2">
<table:table-cell table:style-name="Table35.A5" table:number-columns-spanned="7" office:value-type="string">
<text:p text:style-name="P2493"><text:a xlink:type="simple" xlink:href="#1.2.1.ACTDIMS – ACTION Keyword Dimensions|outline" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link"><text:span text:style-name="T1"><text:bookmark-ref text:reference-format="text" text:ref-name="__RefHeading___Toc4408_421927891">ACTDIMS – ACTION Keyword Dimensions</text:bookmark-ref></text:span></text:a></text:p>
</table:table-cell>
Expand Down
29 changes: 16 additions & 13 deletions parts/chapters/8.fodt
Expand Up @@ -47281,7 +47281,10 @@ Updated with AFR/TSA Rev-D comments and new keywords.</dc:description><meta:init
</text:section-source>
</text:section>
<text:h text:style-name="P17536" text:outline-level="2"><text:bookmark-start text:name="__RefHeading___Toc25311_3671211675"/>Keyword Definitions<text:bookmark-end text:name="__RefHeading___Toc25311_3671211675"/></text:h>
<text:section text:style-name="Sect1" text:name="Section8.3:ADD" text:protected="true">
<text:section text:style-name="Sect1" text:name="Section8.3:ACF" text:protected="true">
<text:section-source xlink:href="subsections/8.3/ACF.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="ACF"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:ADD" text:protected="true">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<text:section text:style-name="Sect1" text:name="Section8.3:ADD" text:protected="true">
<text:section text:style-name="Sect1" text:name="Section8.3:ADD" text:protected="true">

NOt sure whether this is the @hakonhagland's script, but indentation seems a bit messed up here,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😠 Can commit it. What the heck.

<text:section-source xlink:href="subsections/8.3/ADD.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="ADD"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:ADDREG" text:protected="true">
Expand Down Expand Up @@ -47800,12 +47803,12 @@ Updated with AFR/TSA Rev-D comments and new keywords.</dc:description><meta:init
<text:section text:style-name="Sect1" text:name="Section8.3:MESSAGES" text:protected="true">
<text:section-source xlink:href="subsections/8.3/MESSAGES.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="MESSAGES"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:MINVALUE" text:protected="true">
<text:section-source xlink:href="subsections/8.3/MINVALUE.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="MINVALUE"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:MICPPARA" text:protected="true">
<text:section-source xlink:href="subsections/8.3/MICPPARA.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="MICPPARA"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:MINVALUE" text:protected="true">
<text:section-source xlink:href="subsections/8.3/MINVALUE.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="MINVALUE"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:MISC" text:protected="true">
<text:section-source xlink:href="subsections/8.3/MISC.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="MISC"/>
</text:section>
Expand Down Expand Up @@ -47968,6 +47971,9 @@ Updated with AFR/TSA Rev-D comments and new keywords.</dc:description><meta:init
<text:section text:style-name="Sect1" text:name="Section8.3:PVDS" text:protected="true">
<text:section-source xlink:href="subsections/8.3/PVDS.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="PVDS"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:PVSOL" text:protected="true">
<text:section-source xlink:href="subsections/8.3/PVSOL.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="PVSOL"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:PVTG" text:protected="true">
<text:section-source xlink:href="subsections/8.3/PVTG.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="PVTG"/>
</text:section>
Expand All @@ -47980,24 +47986,21 @@ Updated with AFR/TSA Rev-D comments and new keywords.</dc:description><meta:init
<text:section text:style-name="Sect1" text:name="Section8.3:PVTO" text:protected="true">
<text:section-source xlink:href="subsections/8.3/PVTO.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="PVTO"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:PVSOL" text:protected="true">
<text:section-source xlink:href="subsections/8.3/PVSOL.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="PVSOL"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:PVTW" text:protected="true">
<text:section-source xlink:href="subsections/8.3/PVTW.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="PVTW"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:PVTWSALT" text:protected="true">
<text:section-source xlink:href="subsections/8.3/PVTWSALT.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="PVTWSALT"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:PVZG" text:protected="true">
<text:section-source xlink:href="subsections/8.3/PVZG.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="PVZG"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:PYEND" text:protected="true">
<text:section-source xlink:href="subsections/8.3/PYEND.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="PYEND"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:PYINPUT" text:protected="true">
<text:section-source xlink:href="subsections/8.3/PYINPUT.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="PYINPUT"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:PVZG" text:protected="true">
<text:section-source xlink:href="subsections/8.3/PVZG.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="PVZG"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:QHRATING" text:protected="true">
<text:section-source xlink:href="subsections/8.3/QHRATING.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="QHRATING"/>
</text:section>
Expand Down Expand Up @@ -48241,12 +48244,12 @@ Updated with AFR/TSA Rev-D comments and new keywords.</dc:description><meta:init
<text:section text:style-name="Sect1" text:name="Section8.3:STWG" text:protected="true">
<text:section-source xlink:href="subsections/8.3/STWG.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="STWG"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:SURFADDW" text:protected="true">
<text:section-source xlink:href="subsections/8.3/SURFADDW.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="SURFADDW"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:SURF" text:protected="true">
<text:section-source xlink:href="subsections/8.3/SURF.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="SURF"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:SURFADDW" text:protected="true">
<text:section-source xlink:href="subsections/8.3/SURFADDW.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="SURFADDW"/>
</text:section>
<text:section text:style-name="Sect1" text:name="Section8.3:SURFCAPD" text:protected="true">
<text:section-source xlink:href="subsections/8.3/SURFCAPD.fodt" text:filter-name="OpenDocument Text Flat XML" text:section-name="SURFCAPD"/>
</text:section>
Expand Down