Refactor intersection index inside and document what it does #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
atgeirr
reviewed
Nov 16, 2023
blattms
force-pushed
the
refactor-intersection-index-inside
branch
from
0e363cb
to
7fa451e
Compare
We were using the same value incremented by 0 already, anyway. Reduces code.
|
Added another commit that reused indexInInside in boundaryId to reduce code. |
|
jenkins build this please |
|
Checks are green. Do you have more comments? |
|
Apart from those comments on documentation ("idx of the underlying Cartesian grid" -> "idx of the unit cube"), no further comments from my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of switch-case we compute the index directly for Non-NNcs.