cartesianToCompressed changed to unordered multimap #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this serial please |
bska
reviewed
Nov 7, 2023
Comment on lines
39
to
49
| retval.reserve(num_cells); | ||
| if (global_cell) { | ||
| for (int i = 0; i < num_cells; ++i) { | ||
| retval.insert(std::pair<int,int>(global_cell[i], i)); | ||
| } | ||
| } else { | ||
| for (int i = 0; i < num_cells; ++i) { | ||
| retval.insert(std::pair<int,int>(i, i)); | ||
| } | ||
| return retval; | ||
| } | ||
| return retval; |
There was a problem hiding this comment.
If you're changing this anyway, now would be a good time to switch to
retval.emplace(x, y)instead of
retval.insert(std::pair<int,int>(x, y))They do the same thing, effectively, but the former (.emplace()) is (slightly) faster since it constructs the value in-place.
There was a problem hiding this comment.
Thanks for your feedback! Indeed, unordered_map<int, std::vector> is an alternative too. I'll check it out.
Comment on lines
41
to
44
| for (const auto pair : cartesian_to_compressed) | ||
| { | ||
| std::cout << pair.first << " " << pair.second << '\n'; | ||
| } |
There was a problem hiding this comment.
Is this code left over from development? If so, I think we should remove it.
There was a problem hiding this comment.
Opps! Yes, that was supposed to be removed. Thanks for noticing!
aritorto
force-pushed
the
cartesianToCompressedMulti
branch
from
94769bd
to
db56d39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a CpGrid has LGRs, a Cartesian index (key) is associated to more than one compressed index (value). Therefore, this unordered_map now has been replaced by an unordered_multimap, to support multiple value with a same key.