Avoid include of Parser.hpp and Deck.hpp #522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
OpmParserIncludes.hpp
includes the headerparser/Parser.hpp
which transitively brings in half of opm-common. In particular it allowed for silent usage ofDeck
in: #517.With this PR only the "really needed" headers are included with the
OpmParserIncludes.hpp
. If this is merged #517 will need to explicitly include the dependencies from opm-common; which is in my opinion a good thing.As an aside I would really like to reignite this: #401