Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/py action build only one shared library #4029

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Fix/py action build only one shared library #4029

merged 4 commits into from
Apr 30, 2024

Commits on Apr 30, 2024

  1. Correct grammar and unprecise formulations in python/README.md

    @lisajulia
    lisajulia committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d9612d6 View commit details
    Browse the repository at this point in the history

  2. Add environment variable to those tests that depend on python

    @lisajulia
    lisajulia committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    feed862 View commit details
    Browse the repository at this point in the history

  3. Do not create an opm_embedded library as embedded anymore, this is au… 

    …tomatically taken from the globally installed python

There are two reasons for this change:
- Avoid a duplicate module creation
- The code in OPM_EMBEDDED is a copy of PYBIND11_EMBEDDED_MODULE - without the following check:
	if (Py_IsInitialized() != 0) {
            //pybind11_fail("Can't add new modules after the interpreter has been initialized");
        }
  This is causing problems for Python 3.12 and is likely to cause further problems in the future
    @lisajulia
    lisajulia committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    becdd56 View commit details
    Browse the repository at this point in the history

  4. Display a proper error message in case import("opm_embedded") fails i… 

    …n the class PythonInterp
    @lisajulia
    lisajulia committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2b017ba View commit details
    Browse the repository at this point in the history