use DENSITY in CO2STORE runs #3879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
totto82
force-pushed
the
useDensityCo2store
branch
from
f21df76
to
31ab342
Compare
|
jenkins build this please |
totto82
commented
Apr 15, 2024
| const Scalar MmNaCl = 58.44e-3; // molar mass of NaCl [kg/mol] | ||
| // convert to mass fraction | ||
| salinity_[regionIdx] = 1 / ( 1 + 1 / (molality*MmNaCl)); | ||
|
|
There was a problem hiding this comment.
This sets the salinity used by the brine module to compute the fraction of vaporized water in the gas phase. This makes the brine module consistent with the CO2 module. Test is also the reason for the test failure.
|
In the current version, what is the value of surface density that is calculated? |
It is shown in the top of the .PRT file. (It computes it from pressure and temperature in STCOND(usually defaulted)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation the surface density is computed internally using pressure and temperature at stcond and thus DENSITY is ignored. Sometimes it may be beneficial for the user to set the surface density themselves. For instance to make sure that injection rates are consistent etc. This PR changes the behavior of the CO2STORE such that it reads and uses the given surface density from the DENSITY keyword and only compute it internally if DENSITY is not given.