Added: Unit test that provokes the mixed/periodicity failure #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmokstad
referenced
this pull request
Jun 2, 2017
|
test disabled. |
kmokstad
force-pushed
the
periodicity-check
branch
from
3eed8b5
to
f672dbd
Compare
Changed: Mainly cosmetics in TestSIM2D::InjectPatchSolution.
kmokstad
force-pushed
the
periodicity-check
branch
from
f672dbd
to
2a9a91a
Compare
akva2
force-pushed
the
master
branch
6 times, most recently
from
71afb42
to
b4ac149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the fixup commit 8b4e1a9 the only regression test using periodic boundary conditions and mixed dumps core. I think the logic behind the
addPeriodicity()calls does not account for the existence of several bases. Here is a simple unit test that provokes the same error. This has to be re-thinked a bit, but until then that reg-test should be deactivated to avoid the fuss in the nightly builds.