Delete required_model_steps #1640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something to discuss over a drink 😅 Intuitively I would think this is a good idea, but solving all the tests seems hard? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a suggestion for deleting
required_model_stepsfromFlowlineModelas a potential optimisation as discussed on slack. I kept some of the logic to make sure the mass balance model updates correctly depending on the defined feedback frequency.Further, I included
max_dttoFluxBasedModel, as in the original comment it states thatrequired_model_stepsis used "to prevent 'too large' steps". But not sure if this is really needed.whats-new.rst