-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] MIG hr_employee_cost_history #670
[16.0] MIG hr_employee_cost_history #670
Conversation
…roactively in timesheets This module allows to modify retroactively timesheet costs from a given date and store those changes in a new model. @moduon MT-4266
d31c6e3
to
a96172d
Compare
@@ -14,6 +14,7 @@ | |||
"installable": True, | |||
"auto_install": False, | |||
"depends": [ | |||
"hr_hourly_cost", | |||
"hr_timesheet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need hr_timesheet
anymore, do you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was an issue I came across during the migration.
timesheet_cost was renamed to hourly_cost and shipped in another module that only depended on hr. Thats why I added hr_timesheet so that I could access to account.analytic relational data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a96172d
to
2fc4dc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
@alexey-pelykh This is the fwport of #635 which you just merged. Would you mind merging here too please? Thanks! |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 1d26f79. Thanks a lot for contributing to OCA. ❤️ |
This migration comes from this PR.
@moduon @EmilioPascual Please review it if you can.
MT-4266