Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] MIG hr_employee_cost_history #670

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

edlopen
Copy link
Member

@edlopen edlopen commented Apr 11, 2024

This migration comes from this PR.

@moduon @EmilioPascual Please review it if you can.

MT-4266

…roactively in timesheets

This module allows to modify retroactively timesheet costs from a given date and store those changes
in a new model.

@moduon MT-4266
@edlopen edlopen force-pushed the 16.0-mig-hr_employee_cost_history branch from d31c6e3 to a96172d Compare April 11, 2024 09:23
@edlopen edlopen marked this pull request as ready for review April 11, 2024 11:49
@@ -14,6 +14,7 @@
"installable": True,
"auto_install": False,
"depends": [
"hr_hourly_cost",
"hr_timesheet",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need hr_timesheet anymore, do you?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an issue I came across during the migration.

timesheet_cost was renamed to hourly_cost and shipped in another module that only depended on hr. Thats why I added hr_timesheet so that I could access to account.analytic relational data.

Copy link

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edlopen edlopen force-pushed the 16.0-mig-hr_employee_cost_history branch from a96172d to 2fc4dc5 Compare April 12, 2024 07:22
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@yajo
Copy link
Member

yajo commented Apr 12, 2024

@alexey-pelykh This is the fwport of #635 which you just merged. Would you mind merging here too please? Thanks!

@alexey-pelykh
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-670-by-alexey-pelykh-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a53a07e into OCA:16.0 Apr 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1d26f79. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 16.0-mig-hr_employee_cost_history branch April 15, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants