New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] hr_timesheet_begin_end: Change line overlap domain from looking for user to employee #657
Conversation
…ooking for user to employee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional approval
This PR has the |
@guewen @luismontalba @ernestotejeda @astirpe @schhatbar-initos Hello, I want to merge the changes into the module. Can someone approve the changes? |
/ocabot merge patch |
Sorry @dtec-landoo you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
@pedrobaeza Ready to merge please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 573628d. Thanks a lot for contributing to OCA. ❤️ |
With this PR, the only thing I want to change is to replace the user with the employee in the domain. I don't see any logic in checking if the users are the same, since sometimes it can happen that the employee doesn't have a user. In other words, the employee will never be false, whereas the user might be.