[16] attachment synchronize : Improve remote file import management #2923
+97
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @GSLabIt, @sebastienbeau, @bealdav, |
GSLabIt
approved these changes
Apr 24, 2024
…ver : If one task is failing, keep processing the others Commit fir attachment imported after each file to be sure not to loose any data, when deleting on remote after import for example
florian-dacosta
force-pushed
the
16-task-import-eroor-management
branch
from
bc70a0f
to
e6a8b97
Compare
kevinkhao
approved these changes
Apr 24, 2024
|
This PR has the |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c6de13f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current problems are the following :
When import multiple files from a remote server, if an error occurs after the first file, we risk loosing data, because, the first file(s) imported could have been deleted/renamed on remote server.
We need to commit after each imported file to ensure we won't loose any data.
If one import task fails, the whole cron stops. It means if we import files from multiple remote server and the first remote server is unavailable, all import from all remote will be blocked.
We add a warning in the log if there is a failure for a remote but don't block the rest of the process.
@kevinkhao @bealdav @GSLabIt @sebastienbeau