Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] iap_alternative_provider: Migration to 17.0 #2914

Merged
merged 34 commits into from
May 14, 2024
Merged

[17.0][MIG] iap_alternative_provider: Migration to 17.0 #2914

merged 34 commits into from
May 14, 2024

Conversation

luka-guru
Copy link

@luka-guru luka-guru commented Apr 19, 2024 •
edited

Minimal changes for iap_alternative_provider to work on Odoo 17

sebastienbeau and others added 30 commits April 19, 2024 09:51
@sebastienbeau
[12.0][ADD] add base_iap_alternative
7fb1208
@oca-travis
[UPD] Update iap_alternative_provider.pot
81e21b8
@OCA-git-bot
[UPD] README.rst
3faa833
@OCA-git-bot
[ADD] icon.png
75717f4
@hendrixcosta
[IMP] iap_alternative_provider: black, isort, prettier
64c0803
[IMP] iap_alternative_provider: black, isort, prettier
702ca32
[MIG] iap_alternative_provider: Migration to 14.0
71ff16a
@sebastienbeau
[FIX] fix multicompany field
842b779
@oca-travis
[UPD] Update iap_alternative_provider.pot
36fc998
@OCA-git-bot
[UPD] README.rst
e68f34c
@extrememicro
Added translation using Weblate (Catalan)
f2fae1e
@petrus-v
[MIG] iap_alternative_provider: Migration to 15.0
a97b9a9
@petrus-v
[IMP] add unit-tests
dcc804c
@petrus-v
[CHG] remove server_environment dependency
195aec5 
Moving this behaviour in a new module in server-env repo
[UPD] Update iap_alternative_provider.pot
c6fc598
@OCA-git-bot
[UPD] README.rst
a6450c7
@weblate
Update translation files
6de58bd 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-15.0/server-tools-15.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-iap_alternative_provider/
@FernandoRomera
[16.0][MIG] iap_alternative_provider: Migration to 16.0
c14559c
[UPD] Update iap_alternative_provider.pot
0b853d4
@OCA-git-bot
[UPD] README.rst
875dc29
[UPD] Update iap_alternative_provider.pot
40a2fa3
@weblate
Update translation files
8183f0c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-iap_alternative_provider/
@OCA-git-bot
[UPD] README.rst
e7ed2a1
@Ivorra78
Added translation using Weblate (Spanish)
896c78a
@Ivorra78
Translated using Weblate (Spanish)
ce3b05d 
Currently translated at 100.0% (6 of 6 strings)

Translation: server-tools-16.0/server-tools-16.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-iap_alternative_provider/es/
@mymage
Added translation using Weblate (Italian)
7c98541
@mymage
Translated using Weblate (Italian)
4daccee 
Currently translated at 100.0% (6 of 6 strings)

Translation: server-tools-16.0/server-tools-16.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-iap_alternative_provider/it/
@mymage
Translated using Weblate (Italian)
56ddece 
Currently translated at 100.0% (6 of 6 strings)

Translation: server-tools-16.0/server-tools-16.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-iap_alternative_provider/it/
[UPD] Update iap_alternative_provider.pot
9f611e2
@weblate
Update translation files
50b5d9b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-iap_alternative_provider/
mymage and others added 3 commits April 19, 2024 09:51
@mymage
Translated using Weblate (Italian)
b63b598 
Currently translated at 100.0% (7 of 7 strings)

Translation: server-tools-16.0/server-tools-16.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-iap_alternative_provider/it/
@Ivorra78
Translated using Weblate (Spanish)
dd63e4e 
Currently translated at 100.0% (7 of 7 strings)

Translation: server-tools-16.0/server-tools-16.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-iap_alternative_provider/es/
[IMP] iap_alternative_provider: pre-commit auto fixes
6d8cf26
@luka-guru luka-guru changed the title [17.0][MIG] <module: Migration to 17.0 [17.0][MIG] iap_alternative_provider: Migration to 17.0 Apr 19, 2024
@luka-guru luka-guru force-pushed the 17.0-mig-iap_alternative_provider branch from eec4bcf to ad8f2a6 Compare April 23, 2024 13:54
etobella
etobella reviewed Apr 23, 2024
View reviewed changes
iap_alternative_provider/models/iap_account.py Outdated
@@ -9,7 +9,6 @@ class IapAccount(models.Model):
_inherit = "iap.account"
_name = "iap.account"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not needed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the module, but maybe there is a reason it combines both _inherit and _name, cf. https://www.odoo.com/documentation/17.0/developer/reference/backend/orm.html#classical-inheritance

Also, this line is present since 12.0

Copy link
Author

@luka-guru luka-guru May 6, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clarify if you want it kept or removed so we can move forward with the merge.
@vvrossem @etobella

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed, the model already exists and you need to define the name if you want to create a new module or have multiple inheritances. It is not the case

iap_alternative_provider/views/iap_account_view.xml Outdated
@@ -7,14 +7,17 @@
<xpath expr="//group[@name='account']" position="before">
<group string="Info" name="info">
<field name="provider" />
<field name="name" />
<field name="company_ids" position="move" />
<field name="name" position="move" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the move has no sense IMO...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, if name is removed on the model side, it can be removed too on the xml side.

Copy link
Author

@luka-guru luka-guru May 6, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you believe name should be removed from form view I'm happy to do it, just clarify please so we can move on with the merge.
@etobella @vvrossem

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The move was removing the field from the view. Just remove the line.

@max3903 max3903 added this to the 17.0 milestone Apr 23, 2024
@etobella
Copy link
Member

I would recommend to contact original authors of the module and people that did interesting contributions

@sebastienbeau @FernandoRomera @petrus-v @hendrixcosta Can you provide your point of view, please? 🙏

@luka-guru luka-guru force-pushed the 17.0-mig-iap_alternative_provider branch from ad8f2a6 to 06719ba Compare May 14, 2024 06:36
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-2914-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d3e35ad into OCA:17.0 May 14, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b36099a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex approved these changes

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

@etobella etobella Awaiting requested review from etobella

@vvrossem vvrossem Awaiting requested review from vvrossem

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.

None yet