[16.0][IMP] auditlog: prevent creating logs without log lines #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the change detection logic in the write_full and write_fast methods to ensure logs are only generated when significant data changes occur. Previously, compute functions could trigger logging even without actual data modifications, leading to logs that lacked corresponding log lines. This update prevents such redundant logging, optimizing performance and maintaining cleaner log records.
AungKoKoLin1997
force-pushed
the
4483-imp-auditlog
branch
from
bb37332
to
19f6dd2
Compare
|
@oca-server-tools-maintainers |
yostashiro
suggested changes
May 14, 2024
Comment on lines
+404
to
+409
| changes = any( | ||
| old_values[rec_id] != new_values[rec_id] | ||
| for rec_id in self.ids | ||
| if rec_id in old_values and rec_id in new_values | ||
| ) | ||
| if not changes or self.env.user in users_to_exclude: |
There was a problem hiding this comment.
Suggested change
| changes = any( | |
| old_values[rec_id] != new_values[rec_id] | |
| for rec_id in self.ids | |
| if rec_id in old_values and rec_id in new_values | |
| ) | |
| if not changes or self.env.user in users_to_exclude: | |
| if new_values == old_values or self.env.user in users_to_exclude: |
| result = write_fast.origin(self, vals, **kwargs) | ||
| if self.env.user in users_to_exclude: | ||
| if not changes or self.env.user in users_to_exclude: |
There was a problem hiding this comment.
Please check if this doesn't skip log creation when a value is changed to false from something else.
|
This improvement is not valid. I misunderstood compute function behavior and confused. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the change detection logic in the write_full and write_fast methods to ensure logs are only generated when significant data changes occur. Previously, compute functions could trigger logging even without actual data modifications, leading to logs that lacked corresponding log lines. This update prevents such redundant logging, optimizing performance and maintaining cleaner log records.
@qrtl QT4483